New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Switch Component and Documentation #2877
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #2877 +/- ##
==========================================
+ Coverage 88.76% 88.78% +0.02%
==========================================
Files 48 49 +1
Lines 979 990 +11
Branches 382 391 +9
==========================================
+ Hits 869 879 +10
- Misses 74 75 +1
Partials 36 36
Continue to review full report at Codecov.
|
flyingcircle
requested changes
Mar 19, 2021
khushal87
changed the title
Add a Switch Component
Add a Switch Component and Documentation
Mar 19, 2021
flyingcircle
requested changes
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR adds a new Switch Component which was missing in the package
Did you add tests for your changes?
Yes, I have used appropriate testing tools to test.
If relevant, did you update the documentation?
Not yet, looking forward for PR verification and then I will do that for sure.
Summary
This add a new Switch component in the package which will be useful. It inherits all the props of the native switch and provide theme support with better view.
Does this PR introduce a breaking change?
Yes, this can be a breaking change in terms of feature
Other information
NIL
Waiting for your review and feedback of mentors. @flyingcircle Can you review it. Thanks a lot. Reference issue - #2877