Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Switch Component and Documentation #2877

Merged
merged 11 commits into from Mar 21, 2021
Merged

Add a Switch Component and Documentation #2877

merged 11 commits into from Mar 21, 2021

Conversation

khushal87
Copy link
Member

@khushal87 khushal87 commented Mar 18, 2021

What kind of change does this PR introduce?
This PR adds a new Switch Component which was missing in the package

Did you add tests for your changes?
Yes, I have used appropriate testing tools to test.
If relevant, did you update the documentation?
Not yet, looking forward for PR verification and then I will do that for sure.
Summary
This add a new Switch component Capture23 Capture24 in the package which will be useful. It inherits all the props of the native switch and provide theme support with better view.

Does this PR introduce a breaking change?
Yes, this can be a breaking change in terms of feature

Other information
NIL

Waiting for your review and feedback of mentors. @flyingcircle Can you review it. Thanks a lot. Reference issue - #2877

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #2877 (e117e1d) into next (19db829) will increase coverage by 0.02%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2877      +/-   ##
==========================================
+ Coverage   88.76%   88.78%   +0.02%     
==========================================
  Files          48       49       +1     
  Lines         979      990      +11     
  Branches      382      391       +9     
==========================================
+ Hits          869      879      +10     
- Misses         74       75       +1     
  Partials       36       36              
Impacted Files Coverage Δ
src/switch/switch.tsx 90.90% <90.90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19db829...e117e1d. Read the comment docs.

src/switch/switch.tsx Outdated Show resolved Hide resolved
src/switch/switch.tsx Show resolved Hide resolved
src/switch/switch.tsx Show resolved Hide resolved
@khushal87 khushal87 changed the title Add a Switch Component Add a Switch Component and Documentation Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants