Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Component: FAB #2885

Merged
merged 12 commits into from
Mar 22, 2021

Conversation

arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Mar 20, 2021

What kind of change does this PR introduce?
Added New component

Summary

  • Component
  • Documentation
  • Tests

https://material.io/components/buttons-floating-action-button#specs
https://material-ui.com/components/floating-action-button/#floating-action-button-2

Does this PR introduce a breaking change?
No

Other information
#2880

fab.mp4

@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #2885 (0ee2870) into next (9bb7477) will decrease coverage by 0.61%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2885      +/-   ##
==========================================
- Coverage   88.79%   88.18%   -0.62%     
==========================================
  Files          49       50       +1     
  Lines         991     1007      +16     
  Branches      392      402      +10     
==========================================
+ Hits          880      888       +8     
- Misses         75       76       +1     
- Partials       36       43       +7     
Impacted Files Coverage Δ
src/buttons/FAB.tsx 50.00% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb7477...0ee2870. Read the comment docs.

@arpitBhalla
Copy link
Member Author

@flyingcircle Please Review

@flyingcircle
Copy link
Collaborator

If this is basically just a specialized button, why not just use the Button component to make it and have it inherit the ButtonProps? (and stick it under the button dir) That seems like it would simplify down the code a bit.

@arpitBhalla
Copy link
Member Author

@flyingcircle Please Review

src/buttons/FAB.tsx Outdated Show resolved Hide resolved
src/buttons/FAB.tsx Outdated Show resolved Hide resolved
src/buttons/FAB.tsx Outdated Show resolved Hide resolved
src/buttons/FAB.tsx Outdated Show resolved Hide resolved
src/buttons/FAB.tsx Outdated Show resolved Hide resolved
src/buttons/FAB.tsx Show resolved Hide resolved
src/buttons/FAB.tsx Outdated Show resolved Hide resolved
src/buttons/FAB.tsx Outdated Show resolved Hide resolved
@arpitBhalla
Copy link
Member Author

@flyingcircle Please Review

@flyingcircle flyingcircle merged commit bca7bc7 into react-native-elements:next Mar 22, 2021
@arpitBhalla arpitBhalla deleted the fabComponent branch March 22, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants