-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme can now be changed by changing the theme prop #2891
Conversation
@flyingcircle Sorry for reopening this PR again. I have made the necessary changes and made the code much simpler. Can you please review!? I closed that PR because I accidentally messed up with git and deleted that branch. Will be cautious next time. Sorry for trouble |
Codecov Report
@@ Coverage Diff @@
## next #2891 +/- ##
==========================================
+ Coverage 88.20% 88.24% +0.03%
==========================================
Files 50 50
Lines 1009 1012 +3
Branches 402 401 -1
==========================================
+ Hits 890 893 +3
Misses 76 76
Partials 43 43
Continue to review full report at Codecov.
|
@flyingcircle yeah! you are right. We need to detect that. I think I need to get some sleep. I am making too many silly mistakes. |
CI is saying you're failing the unit tests. Please fix first. |
@flyingcircle I have also added |
@flyingcircle Please review! |
@flyingcircle Can you please review! |
What kind of change does this PR introduce?
Added ability to change the theme for a component tree via state change
Fixed issue #2754