Added new Dialog Component #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ative-elements into dialog
Codecov Report
@@ Coverage Diff @@
## next #2911 +/- ##
==========================================
+ Coverage 79.31% 81.37% +2.06%
==========================================
Files 53 61 +8
Lines 1131 1450 +319
Branches 449 642 +193
==========================================
+ Hits 897 1180 +283
- Misses 182 269 +87
+ Partials 52 1 -51
Continue to review full report at Codecov.
|
flyingcircle
requested changes
Mar 28, 2021
|
Thanks a lot for the suggestion! That seems to be a way more elegant way of doing this. I'm on it! |
…ative-elements into dialog
|
Hey @flyingcircle! I apologize for the massive delay in completing this one, I was focusing on finishing my finals in university and the covid vaccine had some weird side effects. But it is finally complete! Kindly review the changes I've made! Looking forward to a merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR introduces a new Dialog component.
Did you add tests for your changes?
Yes, I have written unit tests for this new component
If relevant, did you update the documentation?
Yes, I have updated the documentation to reflect the usage, props, and other information regarding the new Dialog component
Summary
The DIalog component is one that is very important and powerful as it can be used to quickly create a dialog that shows loading context, selection, confirmation, information, and other custom components. I believe this PR aims to solve the absence of such a component in the React Native Elements UI Toolkit. Link to Open Issue -> #2910
I have also submitted a PR to the RNE-app repository for the showcase of the new Chip component for users to fiddle with and understand. (react-native-elements/react-native-elements-app#182)
Preview
@flyingcircle @pranshuchittora Kindly review this PR and let me know if there is anything I can add to it or make it more complete. Looking forward to a merge :)