bugfix: extra style prop for image children container #2933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and solution
I solve the problem of opened issue #2581. There are no breaking changes of project and even of component 😄
Just I've added an extra style property for
Image
to avoid collision between children and image styles.Btw, I didn't expect to see an extra wrapper for children (it's redundant from my perspective) but anyway I solve the problem based on already existing functionality and expectations of constant users.
Did you add tests for your changes?
I've extended one test case to ensure props pass correctly.
If relevant, did you update the documentation?
Yep.