Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and deploy to dist via GitHub CI #2943

Conversation

pranshuchittora
Copy link
Member

@pranshuchittora pranshuchittora commented Apr 3, 2021

Closes #2942

  • CI
  • Docs
  • Update React Native Elements App
  • Update Playground 🚀

Deployed branch -> https://github.com/pranshuchittora/react-native-elements/tree/dist

@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #2943 (9c739b9) into next (d78718c) will decrease coverage by 5.71%.
The diff coverage is 61.93%.

❗ Current head 9c739b9 differs from pull request most recent head 1209c6f. Consider uploading reports for the commit 1209c6f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2943      +/-   ##
==========================================
- Coverage   88.20%   82.49%   -5.72%     
==========================================
  Files          50       51       +1     
  Lines        1009     1068      +59     
  Branches      399      409      +10     
==========================================
- Hits          890      881       -9     
- Misses         76      142      +66     
- Partials       43       45       +2     
Impacted Files Coverage Δ
src/badge/Badge.tsx 100.00% <ø> (ø)
src/config/ThemeProvider.tsx 100.00% <ø> (ø)
src/divider/Divider.tsx 100.00% <ø> (ø)
src/header/Header.tsx 73.07% <ø> (ø)
src/linearProgress/LinearProgress.tsx 60.86% <0.00%> (ø)
src/tile/Tile.tsx 100.00% <ø> (ø)
src/buttons/SpeedDial.tsx 55.00% <55.00%> (ø)
src/slider/Slider.tsx 58.91% <56.25%> (-29.52%) ⬇️
src/social/SocialIcon.tsx 96.66% <80.00%> (+0.11%) ⬆️
src/buttons/Button.tsx 87.80% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78718c...1209c6f. Read the comment docs.

@flyingcircle
Copy link
Collaborator

A solution like this looks good to me!

@pranshuchittora pranshuchittora marked this pull request as ready for review April 7, 2021 11:54
@pranshuchittora
Copy link
Member Author

A solution like this looks good to me!

Great, Updating the docs and the app to support this functionality before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for referencing branch on github instead of npm as the package version
2 participants