Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Sub Component: ListItem Accordion #2953

Merged
merged 6 commits into from
Apr 12, 2021

Conversation

arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Apr 8, 2021

ListItem.Accordion

  • Docs
  • Component

Reference #2940

1617909343734.mp4

I think Expandable in #2944 can be used to expand other components as well not limited to lists, https://material-ui.com/components/accordion/#secondary-heading-and-columns

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #2953 (82b5479) into next (7fdec69) will decrease coverage by 1.27%.
The diff coverage is 5.55%.

❗ Current head 82b5479 differs from pull request most recent head 16114d6. Consider uploading reports for the commit 16114d6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2953      +/-   ##
==========================================
- Coverage   82.49%   81.21%   -1.28%     
==========================================
  Files          51       52       +1     
  Lines        1068     1086      +18     
  Branches      409      419      +10     
==========================================
+ Hits          881      882       +1     
- Misses        142      159      +17     
  Partials       45       45              
Impacted Files Coverage Δ
src/list/ListItem.tsx 73.91% <ø> (ø)
src/list/ListItemAccordion.tsx 5.55% <5.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fdec69...16114d6. Read the comment docs.

@arpitBhalla arpitBhalla marked this pull request as draft April 8, 2021 19:05
@arpitBhalla arpitBhalla marked this pull request as ready for review April 10, 2021 19:28
@arpitBhalla
Copy link
Member Author

@flyingcircle Kindly Review

@flyingcircle flyingcircle linked an issue Apr 12, 2021 that may be closed by this pull request
@flyingcircle flyingcircle merged commit 19566ea into react-native-elements:next Apr 12, 2021
@arpitBhalla arpitBhalla deleted the accordion branch April 13, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Component List Accordion
2 participants