Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chip] Fix onPress #3129

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Conversation

AllInOneYT
Copy link
Contributor

What kind of change does this PR introduce?

Bugfix, forward the onPress function to the button

Did you add tests for your changes?

Yes

If relevant, did you update the documentation?

N/A

Summary

Chip component simply omit the onPress function when specified, this PR attempt to fix that

Close #3128

Does this PR introduce a breaking change?

No

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #3129 (a1d41fe) into next (42a4c65) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a1d41fe differs from pull request most recent head 300780d. Consider uploading reports for the commit 300780d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             next    #3129      +/-   ##
==========================================
+ Coverage   83.85%   83.87%   +0.01%     
==========================================
  Files          78       78              
  Lines        1685     1687       +2     
  Branches      664      666       +2     
==========================================
+ Hits         1413     1415       +2     
  Misses        268      268              
  Partials        4        4              
Impacted Files Coverage Δ
src/Chip/Chip.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a4c65...300780d. Read the comment docs.

Copy link
Member

@khushal87 khushal87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the code with the latest code in the next branch. and push the changes with new modifications adding comments for the props you have added.

@AllInOneYT
Copy link
Contributor Author

Please update the code with the latest code in the next branch. and push the changes with new modifications adding comments for the props you have added.

done, no additional prop was added. The onPress prop was already there but got omitted before.

@flyingcircle flyingcircle merged commit a73b5dc into react-native-elements:next Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chip] onPress not working
4 participants