Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] Reddit social icon #3146

Merged
merged 8 commits into from
Aug 10, 2021
Merged

Conversation

sanand34
Copy link
Contributor

@sanand34 sanand34 commented Jul 16, 2021

What kind of change does this PR introduce? refactoring

Did you add tests for your changes? No

If relevant, did you update the documentation? No

Summary
Tested this on react native elements expo app by changing this package in the node modules

Does this PR introduce a breaking change? No

Other information

@sanand34 sanand34 changed the title Added reddit social icon with its logo color [Add] Reddit social icon Jul 16, 2021
@flyingcircle
Copy link
Collaborator

Please clean up code.

@netlify
Copy link

netlify bot commented Aug 9, 2021

✔️ Deploy Preview for react-native-elements canceled.

🔨 Explore the source changes: 1d3368b

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native-elements/deploys/6111ef65bcac180007332634

@sanand34
Copy link
Contributor Author

sanand34 commented Aug 9, 2021

I cleaned up the code

@flyingcircle
Copy link
Collaborator

The prettier check is still failing. There's a prettify command that you should be able to run to test that out locally.

@flyingcircle
Copy link
Collaborator

It could also just be that you need to merge in the latest next branch.

@sanand34
Copy link
Contributor Author

sanand34 commented Aug 10, 2021

Screen Shot 2021-08-10 at 9 22 56 AM
Screen Shot 2021-08-10 at 9 45 12 AM

@sanand34
Copy link
Contributor Author

Ran both prettify and test commands locally now after cleaning up the code again.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #3146 (398d738) into next (d9bd689) will not change coverage.
The diff coverage is n/a.

❗ Current head 398d738 differs from pull request most recent head 1d3368b. Consider uploading reports for the commit 1d3368b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             next    #3146   +/-   ##
=======================================
  Coverage   83.92%   83.92%           
=======================================
  Files          78       78           
  Lines        1692     1692           
  Branches      678      678           
=======================================
  Hits         1420     1420           
  Misses        267      267           
  Partials        5        5           
Impacted Files Coverage Δ
src/SocialIcon/SocialIcon.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9bd689...1d3368b. Read the comment docs.

@flyingcircle flyingcircle merged commit 5e4f83a into react-native-elements:next Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants