#3213 Remove deprecated Keyboard.removeListener #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for react-native-elements failed. 🔨 Explore the source changes: 8e9adb5 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native-elements/deploys/61e13ba54c8957000a721454 |
|
Can you resolve the conflicts |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Gustav Haglund <gustav.haglund@nordnet.se>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Gustav Haglund <gustav.haglund@nordnet.se>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Gustav Haglund <gustav.haglund@nordnet.se>
arpitBhalla
pushed a commit
that referenced
this pull request
Mar 17, 2022
Co-authored-by: Gustav Haglund <gustav.haglund@nordnet.se>
arpitBhalla
pushed a commit
that referenced
this pull request
Mar 19, 2022
Co-authored-by: Gustav Haglund <gustav.haglund@nordnet.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes tests where added.
If relevant, did you update the documentation?
Not relevant
Summary
Removes the depricated Keyboard.removeListener function and uses remove function returned on the addListener event.
https://reactnative.dev/docs/keyboard#removelistener
Fixes #3213