Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FAB): add small size style #3322

Merged
merged 9 commits into from Jan 31, 2022
Merged

Conversation

sumj25
Copy link
Contributor

@sumj25 sumj25 commented Jan 31, 2022

What kind of change does this PR introduce?

Fix Fab button with title size bug.

Summary
Fab button with the title does not change on size small. Fix this issue.

Other information

@arpitBhalla arpitBhalla changed the title Fix FAB button fix(FAB): add small size style Jan 31, 2022
@arpitBhalla arpitBhalla linked an issue Jan 31, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #3322 (d069ad5) into next (48609e8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head d069ad5 differs from pull request most recent head 8681197. Consider uploading reports for the commit 8681197 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             next    #3322      +/-   ##
==========================================
+ Coverage   79.93%   79.96%   +0.02%     
==========================================
  Files          88       88              
  Lines        1660     1662       +2     
  Branches      729      731       +2     
==========================================
+ Hits         1327     1329       +2     
  Misses        328      328              
  Partials        5        5              
Impacted Files Coverage Δ
packages/base/src/FAB/FAB.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48609e8...8681197. Read the comment docs.

@arpitBhalla arpitBhalla merged commit b4a7296 into react-native-elements:next Jan 31, 2022
@arpitBhalla
Copy link
Member

Thanks for your contribution 🎉

github-actions bot pushed a commit that referenced this pull request Jan 31, 2022
github-actions bot pushed a commit that referenced this pull request Jan 31, 2022
github-actions bot pushed a commit that referenced this pull request Jan 31, 2022
arpitBhalla pushed a commit that referenced this pull request Mar 17, 2022
arpitBhalla pushed a commit that referenced this pull request Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAB size does nothing
3 participants