Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CheckBox): add disabled, disabledTitleStyle, disabledStyle props #3430

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

kedar09
Copy link
Contributor

@kedar09 kedar09 commented Mar 30, 2022

Fixes # (issue)
This change were made in response to this issue : #3389

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Additional context

Added props to CheckBox component

  • disabled : boolean
  • disabledStyle : disabled container style
  • disabledTitleStyle : disabled title style

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #3430 (612f84a) into next (3567bab) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             next    #3430      +/-   ##
==========================================
+ Coverage   78.22%   78.27%   +0.04%     
==========================================
  Files          87       87              
  Lines        1768     1772       +4     
  Branches      780      784       +4     
==========================================
+ Hits         1383     1387       +4     
  Misses        380      380              
  Partials        5        5              
Impacted Files Coverage Δ
packages/base/src/CheckBox/CheckBox.tsx 94.28% <100.00%> (+0.73%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla changed the title CheckBox - disabled, disabledTitleStyle, disabledStyle props added feat(CheckBox): add disabled, disabledTitleStyle, disabledStyle props Mar 30, 2022
@arpitBhalla
Copy link
Member

You need to update docs, Run yarn docs-build-api

@arpitBhalla arpitBhalla merged commit d35df60 into react-native-elements:next Mar 30, 2022
@arpitBhalla arpitBhalla linked an issue Mar 30, 2022 that may be closed by this pull request
github-actions bot pushed a commit that referenced this pull request Mar 30, 2022
…#3430)

* checkbox disabled disabledTitleStyle disabledStyle props added

* updated docs
github-actions bot pushed a commit that referenced this pull request Mar 30, 2022
…#3430)

* checkbox disabled disabledTitleStyle disabledStyle props added

* updated docs
github-actions bot pushed a commit that referenced this pull request Mar 30, 2022
…#3430)

* checkbox disabled disabledTitleStyle disabledStyle props added

* updated docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox disabled like ButtonGroup
2 participants