Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SearchBar): typescript errors #3437

Merged
merged 4 commits into from
Apr 8, 2022

Conversation

arpitBhalla
Copy link
Member

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #3437 (d9c5c88) into next (f4db70d) will not change coverage.
The diff coverage is 42.85%.

❗ Current head d9c5c88 differs from pull request most recent head 58eda42. Consider uploading reports for the commit 58eda42 to get more accurate results

@@           Coverage Diff           @@
##             next    #3437   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files          87       87           
  Lines        1775     1775           
  Branches      787      786    -1     
=======================================
  Hits         1389     1389           
  Misses        381      381           
  Partials        5        5           
Impacted Files Coverage Δ
packages/base/src/SearchBar/SearchBar-android.tsx 62.29% <ø> (ø)
packages/base/src/SearchBar/SearchBar-default.tsx 74.46% <ø> (ø)
packages/base/src/SearchBar/SearchBar-ios.tsx 49.27% <ø> (ø)
packages/base/src/SearchBar/SearchBar.tsx 73.33% <42.85%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit ec01b65 into react-native-elements:next Apr 8, 2022
@arpitBhalla arpitBhalla deleted the searchbar-fixes branch April 8, 2022 19:49
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants