Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Chip): border radius on tap #3442

Merged

Conversation

kedar09
Copy link
Contributor

@kedar09 kedar09 commented Apr 5, 2022

Fixes # (issue)
This changes were made in response to this issue : #3159

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • My changes generate no new warnings

Additional context

Chip animation is square but it has borderRadius, this issue only get when type="outline"
so i have added containerStyle={{ borderRadius: 30 }}.

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #3442 (b7349e6) into next (b691121) will not change coverage.
The diff coverage is n/a.

❗ Current head b7349e6 differs from pull request most recent head 3f858d6. Consider uploading reports for the commit 3f858d6 to get more accurate results

@@           Coverage Diff           @@
##             next    #3442   +/-   ##
=======================================
  Coverage   78.27%   78.27%           
=======================================
  Files          87       87           
  Lines        1772     1772           
  Branches      784      768   -16     
=======================================
  Hits         1387     1387           
  Misses        380      380           
  Partials        5        5           
Impacted Files Coverage Δ
packages/base/src/Chip/Chip.tsx 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla changed the title fix(Chip):- animation issue fix(Chip): border radius on tap Apr 5, 2022
@arpitBhalla arpitBhalla linked an issue Apr 5, 2022 that may be closed by this pull request
@arpitBhalla arpitBhalla merged commit 2720463 into react-native-elements:next Apr 8, 2022
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

animation bug in Chip element
2 participants