feat(Overlay): add KeyboardAvoidingView #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into overlay_ios_KeyboardAvoidingView
Codecov Report
@@ Coverage Diff @@
## next #3453 +/- ##
=======================================
Coverage 79.40% 79.40%
=======================================
Files 87 87
Lines 1821 1821
Branches 812 812
=======================================
Hits 1446 1446
Misses 370 370
Partials 5 5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@kedar09 did you tested it for iOS too? |
yes I have tested on iOS and android |
arpitBhalla
reviewed
May 21, 2022
| testID="RNE__Overlay__Container" | ||
| style={styles.container} | ||
| pointerEvents="box-none" | ||
| behavior={Platform.OS === 'ios' ? 'padding' : 'height'} |
There was a problem hiding this comment.
Can move outside (ideally in helpers folder)
…/kedar09/react-native-elements into overlay_ios_KeyboardAvoidingView
arpitBhalla
approved these changes
May 22, 2022
tsukudabuddha
added a commit
to tsukudabuddha/CurrencyExchange
that referenced
this pull request
Jun 6, 2022
arpitBhalla
changed the title
arpitBhalla
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
This change were made in response to this issue : #2748
Type of change
How Has This Been Tested?
exampleappChecklist
Additional context
In Overlay, KeyboardAvoidingView is not working in iOS.