Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SpeedDial): Left placement for Actions #3479

Merged

Conversation

arpitBhalla
Copy link
Member

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@arpitBhalla arpitBhalla linked an issue Apr 27, 2022 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #3479 (5def9eb) into next (95df31f) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             next    #3479      +/-   ##
==========================================
- Coverage   78.20%   78.20%   -0.01%     
==========================================
  Files          87       87              
  Lines        1776     1780       +4     
  Branches      787      791       +4     
==========================================
+ Hits         1389     1392       +3     
- Misses        382      383       +1     
  Partials        5        5              
Impacted Files Coverage Δ
packages/base/src/SpeedDial/SpeedDial.tsx 96.00% <80.00%> (-4.00%) ⬇️
packages/base/src/SpeedDial/SpeedDial.Action.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit d006fe9 into react-native-elements:next Apr 27, 2022
@arpitBhalla arpitBhalla deleted the speed-dial-actions branch April 27, 2022 18:23
github-actions bot pushed a commit that referenced this pull request Apr 27, 2022
* update speeddial

* update speeddial
github-actions bot pushed a commit that referenced this pull request Apr 27, 2022
* update speeddial

* update speeddial
github-actions bot pushed a commit that referenced this pull request Apr 27, 2022
* update speeddial

* update speeddial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed Dial Placement left doesnt move the speed dial actions
1 participant