Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update extending theme #3482

Merged
merged 3 commits into from
Apr 28, 2022
Merged

docs: update extending theme #3482

merged 3 commits into from
Apr 28, 2022

Conversation

lucksp
Copy link
Contributor

@lucksp lucksp commented Apr 27, 2022

Motivation

While working though how to get a proper custom & extended theme #3473 I thought the documents could use a small massage.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@arpitBhalla arpitBhalla changed the title Chore/pl update docs docs: update extending theme Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #3482 (4595c47) into next (d1ac3fc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3482   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files          87       87           
  Lines        1774     1774           
  Branches      790      790           
=======================================
  Hits         1393     1393           
  Misses        376      376           
  Partials        5        5           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit a36fbd7 into react-native-elements:next Apr 28, 2022
@arpitBhalla
Copy link
Member

arpitBhalla commented Apr 28, 2022

Thank you for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants