Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ListItem): Accordion children areas were not hidden #3517

Conversation

monk-lee
Copy link
Contributor

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #3517 (b35a680) into next (350ef21) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             next    #3517      +/-   ##
==========================================
- Coverage   79.21%   79.18%   -0.04%     
==========================================
  Files          87       87              
  Lines        1804     1806       +2     
  Branches      791      810      +19     
==========================================
+ Hits         1429     1430       +1     
- Misses        368      369       +1     
  Partials        7        7              
Impacted Files Coverage Δ
packages/base/src/ListItem/ListItem.Accordion.tsx 77.77% <50.00%> (-2.23%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit dc1d369 into react-native-elements:next May 13, 2022
github-actions bot pushed a commit that referenced this pull request May 13, 2022
Co-authored-by: MONK_LEE <monk@senacorps.com>
github-actions bot pushed a commit that referenced this pull request May 13, 2022
Co-authored-by: MONK_LEE <monk@senacorps.com>
@arpitBhalla
Copy link
Member

Thanks

@arpitBhalla arpitBhalla linked an issue May 13, 2022 that may be closed by this pull request
1 task
@monk-lee monk-lee deleted the fixed-accordion-children-hidden branch May 23, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

White space when using ListItem.Accordion
2 participants