Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(withTheme): add spacing to non-ThemeProvider components #3525

Merged

Conversation

arpitBhalla
Copy link
Member

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #3525 (81f8469) into next (eaeacb3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3525   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files          87       87           
  Lines        1806     1806           
  Branches      810      810           
=======================================
  Hits         1430     1430           
  Misses        369      369           
  Partials        7        7           
Impacted Files Coverage Δ
packages/themed/src/config/withTheme.tsx 75.67% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit 2ec13f9 into react-native-elements:next May 16, 2022
@arpitBhalla arpitBhalla deleted the button-non-themeprovider branch May 17, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant