Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Avatar): remove activeOpacity prop #3618

Merged

Conversation

dakshbhardwaj
Copy link
Contributor

@dakshbhardwaj dakshbhardwaj commented Aug 22, 2022

Motivation

ActiveOpacity was not working on the Avatar component.

Fix: #3552

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@dakshbhardwaj dakshbhardwaj changed the title Docs/avatar component Fixed the documentation of Avatar component Aug 22, 2022
@dakshbhardwaj
Copy link
Contributor Author

@arpitBhalla can you please review it?

@arpitBhalla arpitBhalla changed the title Fixed the documentation of Avatar component docs(Avatar): remove activeOpacity prop Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #3618 (12cef67) into next (b3fc37e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3618   +/-   ##
=======================================
  Coverage   79.29%   79.29%           
=======================================
  Files          87       87           
  Lines        1811     1811           
  Branches      802      802           
=======================================
  Hits         1436     1436           
  Misses        369      369           
  Partials        6        6           
Impacted Files Coverage Δ
packages/base/src/Avatar/Avatar.tsx 97.22% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla merged commit 32d812a into react-native-elements:next Sep 16, 2022
github-actions bot pushed a commit that referenced this pull request Sep 16, 2022
github-actions bot pushed a commit that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

activeOpacity does not work on mobile
2 participants