Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Header): add edges support for SafeAreaView #3741

Conversation

thekevshow
Copy link
Contributor

…pport proper padding disable for web

Motivation

I was having issues using the header within a modal, which is a very useful component, and I am sure there could be other use cases. To be able to control the SafeAreaView edges, because on a PWA particularly this causes extra padding etc in unwanted areas.

Fixes # Header SafeAreaViews that I have somewhat seen could have been maybe fixed within the issues backlog.

Type of change

  • [X ] New feature (non-breaking change which adds functionality)
  • [X ] This change requires a documentation update

How Has This Been Tested?

I have used the project change within my own code base to test and ran existing tests to make sure no breaking changes would occur.

  • [X ] Checked with example app

Checklist

  • [ X] My code follows the style guidelines of this project
  • [X ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • [ X] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Merging #3741 (f2807a6) into next (eb09131) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head f2807a6 differs from pull request most recent head eb19997. Consider uploading reports for the commit eb19997 to get more accurate results

@@            Coverage Diff             @@
##             next    #3741      +/-   ##
==========================================
+ Coverage   79.42%   79.44%   +0.01%     
==========================================
  Files          87       87              
  Lines        1823     1824       +1     
  Branches      806      796      -10     
==========================================
+ Hits         1448     1449       +1     
  Misses        370      370              
  Partials        5        5              
Impacted Files Coverage Δ
packages/base/src/Header/Header.tsx 96.15% <100.00%> (+0.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla changed the title add edges support for SafeAreaView so that modals using header can su… feat(Header): add edges support for SafeAreaView Jan 24, 2023
@arpitBhalla arpitBhalla merged commit c8e8637 into react-native-elements:next Jan 24, 2023
github-actions bot pushed a commit that referenced this pull request Jan 24, 2023
Co-authored-by: thekevshow <kevin.kelly@>
Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jan 24, 2023
Co-authored-by: thekevshow <kevin.kelly@>
Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
@thekevshow thekevshow deleted the Add-Header-SafeArea-Edges-Options branch January 25, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants