Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: absolute path issue in link for consistent URLs #3856

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

abdulbasithqb
Copy link
Contributor

@abdulbasithqb abdulbasithqb commented Nov 9, 2023

Motivation

Fixes #3855

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Additional context

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to update the versioned docs. Please remove the change and this PR will be good to go. Thanks 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, revered the changes

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43d1587) 79.69% compared to head (553791d) 79.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3856   +/-   ##
=======================================
  Coverage   79.69%   79.69%           
=======================================
  Files          87       87           
  Lines        1842     1842           
  Branches      818      818           
=======================================
  Hits         1468     1468           
  Misses        369      369           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khushal87
Copy link
Member

Please update the branch with the base branch so that I can merge the PR.

@abdulbasithqb
Copy link
Contributor Author

Please update the branch with the base branch so that I can merge the PR.

Done

@khushal87 khushal87 merged commit da3a34e into react-native-elements:next Dec 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Native CLI invalid documentation link
3 participants