Add label for the Input component
#990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #990 +/- ##
=======================================
Coverage 54.36% 54.36%
=======================================
Files 34 34
Lines 607 607
Branches 112 112
=======================================
Hits 330 330
Misses 220 220
Partials 57 57
Continue to review full report at Codecov.
|
iRoachie
reviewed
Mar 13, 2018
src/input/Input.js
Outdated
| label != null && | ||
| <Text style={[styles.label, labelStyle]}> | ||
| {label} | ||
| </Text> |
There was a problem hiding this comment.
Should be the same as label && element not so? Any reason why explicitly checking for null?
There was a problem hiding this comment.
Yea I was thinking about the case where label is an empty string, but I can't think about any use case for that
src/input/Input.js
Outdated
| @@ -101,9 +111,9 @@ class Input extends Component { | |||
| </View> | |||
| )} | |||
| </Animated.View> | |||
| {displayError && ( | |||
| {errorMessage != null && ( | |||
xavier-villelegier
force-pushed
the
input-label
branch
from
6736bf2
to
729a0a9
Compare
|
Example app for the last commit (729a0a9): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #892
Associated PR for the example app: react-native-elements/react-native-elements-app#48
Props changes
labeladds a label on top of the InputlabelStyleadds style to the labeldisplayErrorprops. If theerrorMessageis not null, I suppose there is an error to display…I basically took back the style of the old
FormLabelResult