Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate project from rnpm to react-native.config.js #692

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Migrate project from rnpm to react-native.config.js #692

merged 3 commits into from
Aug 27, 2019

Conversation

ja-bravo
Copy link
Contributor

@ja-bravo ja-bravo commented Jul 9, 2019

Summary

Due to an update to the RN CLI we need to migrate from rnpm to react-native.config.js.
It gets rid of the following warning

warn The following packages use deprecated "rnpm" config that will stop working from next release:
  - react-native-google-signin: https://github.com/react-native-community/react-native-google-signin
Please notify their maintainers about it. You can find more details at https://github.com/react-native-community/cli/blob/master/docs/configuration.md#migration-guide.

@ShaMan123
Copy link

+1

@@ -0,0 +1,7 @@
module.exports = {
project: {
Copy link

@ShaMan123 ShaMan123 Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be dependency instead of project?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module.exports = {
    dependency: {
        platforms: {
            ios: {
                project: 'ios/RNGoogleSignin.xcodeproj'
            }
        }
    }
};

@vonovak
Copy link
Member

vonovak commented Jul 14, 2019

First, let me just say that the config option has been there for a long time and I'm not even sure if it needs to be there. Can someone verify if we need to include config for rn-cli?

@vonovak vonovak merged commit ce99dd3 into react-native-google-signin:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants