Fix android leaks #2141
Merged
Fix android leaks #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My last commit also ensure that |
renchap
force-pushed
the
fix-android-leaks
branch
from
a5fac81
to
5107c68
Compare
|
This has now been tested on Android 9 as well.
I also removed my commit replacing the byte-copy loops with |
Johan-dutoit
previously approved these changes
Jun 12, 2023
|
@renchap thanks for the changes! Please resolve conflicts. Will review/merge then. |
Streams and file descriptors needs to be closed when no longer used. I converted those to try-with-resources syntax, so they are automatically closed after the block ends.
…so let's use a custom wrapper around it
renchap
force-pushed
the
fix-android-leaks
branch
from
5107c68
to
17b904c
Compare
Johan-dutoit
approved these changes
Jun 15, 2023
|
🎉 This PR is included in version 5.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation (required)
While working on solving #2138, @huextrat noticed that the various streams and descriptors were never closed.
This is leaking a lot of resources.
I converted those to try-with-resources syntax, so they are automatically closed after the block ends.
Test Plan (required)
I tested various files and videos with the example app, and did not notice any issue.
I also enabled
StrictModeon the example app (see https://wh0.github.io/2020/08/12/closeguard.html) and it no longer detects non-closed resources.