Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix android leaks #2141

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Fix android leaks #2141

merged 3 commits into from
Jun 15, 2023

Commits on Jun 13, 2023

  1. fix(android): fix a lot of leaks 

    Streams and file descriptors needs to be closed when no longer used.

I converted those to try-with-resources syntax, so they are
automatically closed after the block ends.
    @renchap
    renchap committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8d5f900 View commit details
    Browse the repository at this point in the history

  2. fix(android) Ensure MediaMetadataRetriever is closed

    @renchap
    renchap committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ccdf836 View commit details
    Browse the repository at this point in the history

  3. MediaMetadataRetriever does not inherits AutoCloseable until API 29, … 

    …so let's use a custom wrapper around it
    @renchap
    renchap committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    17b904c View commit details
    Browse the repository at this point in the history