Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug that can occur when user has multiple gallery apps #1114

Merged
merged 4 commits into from
Aug 30, 2019

Conversation

johanforslund
Copy link
Contributor

  • Explain the motivation for making this change.
  • Provide a test plan demonstrating that the code is solid.
  • Match the code formatting of the rest of the codebase.
  • Target the master branch, NOT a "stable" branch.

Motivation (required)

Targeting #1017. This bug occurs on Android when user has multiple gallery apps installed on the phone and tries to choose from library. It seems to only occur when launchMode is set to 'singleInstance' in Android Manifest.

This fix starts an Intent Chooser which solves this problem when using 'singleInstance'.

Test Plan (required)

Tried running it on Android Pie physical phone and on emulator.

@Johan-dutoit Johan-dutoit added 🐛 Bug Android Platform: Android labels Jul 4, 2019
@mariot
Copy link

mariot commented Aug 6, 2019

Hi!

Any news on this?

Thanks

@johanforslund
Copy link
Contributor Author

Options now have a new option called 'chooseWhichLibraryTitle'. If not set, it uses the default title from OS.

@Johan-dutoit
Copy link
Collaborator

Johan-dutoit commented Aug 7, 2019

@johanforslund
Copy link
Contributor Author

Fixed!

@Johan-dutoit Johan-dutoit merged commit aacf1b2 into react-native-image-picker:master Aug 30, 2019
@mariot
Copy link

mariot commented Aug 30, 2019

Great news! Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Platform: Android 🐛 Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants