fix(android): android gradle plugin 8 compatibility #644
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @friederbluemle would really love to get this one merged in and released for linear gradient so I don't need to maintain a patch or fork! thanks! |
|
Is there any news on this being merged? |
|
Any chance this will be merged relatively soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Supercedes #614 which is not backwards compatible
This is the minimum required change for this module to work on react-native 0.73 which includes android gradle plugin 8
It is backwards compatible with all previous versions of react-native that include android gradle plugin 7 or even 6 and older
It is similar to changes I needed to do as react-native-firebase maintainer --> invertase/react-native-firebase@b52d0ce
Test Plan
With apologies, you have to alter an app that integrates this module to use android gradle plugin 8 to see the error, it's difficult to do that in repos I'm proposing these changes in because bumping to android gradle plugin 8 requires a large amount of transitive dependency changes in CI
I have integrated this in an app and tested it, and done similar work as maintainer of react-native-firebase, react-native-netinfo and react-native-device-info, and I'm now pushing these out to the repos
Cheers