Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running for IOS, support for Google maps is on its way? #633

Closed
mattiLeBlanc opened this issue Oct 1, 2016 · 28 comments
Closed

When running for IOS, support for Google maps is on its way? #633

mattiLeBlanc opened this issue Oct 1, 2016 · 28 comments

Comments

@mattiLeBlanc
Copy link

I was going through the example and saw that for IOS the Apple maps are used. I personally don't like the look of that so I was wondering if I can also for it to run Google maps on IOS?
Is it using a webversion (I see urls to apple maps and google maps in the project) or is using a native component?

I have also been playing with Google SDK example:
https://github.com/Pod-Point-Open-Source/react-native-maps

Not sure what the benefits are of using the SDK over a webversion?

@jgkim
Copy link

jgkim commented Oct 6, 2016

Support Google Maps on iOS has been merged.

@mattiLeBlanc
Copy link
Author

Splenid. I will have a look.
This is not the sdk but a webversion, right?
Any performance issues over the sdk?

On Thursday, 6 October 2016, James G. Kim notifications@github.com wrote:

Support Google Maps on iOS
#548 has been merged.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#633 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFCkqyBa4uc4rACfvO4bMw6YqCSLupl-ks5qxHq8gaJpZM4KLq9q
.

@jgkim
Copy link

jgkim commented Oct 6, 2016

@mattiLeBlanc It's based on the SDK.

@mattiLeBlanc
Copy link
Author

Awesome!

On Thursday, 6 October 2016, James G. Kim notifications@github.com wrote:

@mattiLeBlanc https://github.com/mattiLeBlanc It's based on the SDK.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#633 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFCkq6OEnn6IpcEEZ9t70k7z-z0AMF14ks5qxNrHgaJpZM4KLq9q
.

@gilbox gilbox closed this as completed Oct 7, 2016
@joewoodhouse
Copy link

joewoodhouse commented Oct 11, 2016

Has anyone managed to install this properly? I'm trying to follow the install instructions but just keep hitting problems. All I get is "AirGoogleMaps dir must be added to your project". I've tried following the instructions here: https://github.com/airbnb/react-native-maps/blob/master/docs/installation.md (Option1). When it says "Drag the folder" I assume I must be doing that wrong. Am I supposed to be loading the .xcodeproj or .xcworkspace to drag the folders in to? Is it possible to do that on the command-line?

Could someone just paste the actual Podfile required (rather than this https://github.com/airbnb/react-native-maps/blob/master/example/ios/Podfile which is a smorgasbord of bits of a Podfile, to me?)

(Apologies, I'm from a cordova background where we don't touch stuff like this :) )

@ippa
Copy link

ippa commented Oct 11, 2016

I second @joewoodhouse , I can't seem to quite get it right, more detailed instructions would be greatly appreciated.

@mattiLeBlanc
Copy link
Author

@joewoodhouse maybe have a look at the SDK implementation of this Google maps plugin:
https://github.com/Pod-Point-Open-Source/react-native-maps

I got it to work and I have to do some stuff in Xcode with my project. Maybe you need to do the same for the AirBnB implementation

@gilbox
Copy link
Contributor

gilbox commented Oct 12, 2016

@joewoodhouse

When it says "Drag the folder" I assume I must be doing that wrong. Am I supposed to be loading the .xcodeproj or .xcworkspace to drag the folders in to? Is it possible to do that on the command-line?

Drag the folder from a finder window, into your xCode project.

Could someone just paste the actual Podfile required (rather than this https://github.com/airbnb/react-native-maps/blob/master/example/ios/Podfile which is a smorgasbord of bits of a Podfile, to me?)

If you are using Option1, you can ignore all of the commented code in the example Podfile.

@joewoodhouse
Copy link

@gilbox Yep that's what I've done, and I still get the same errors as above.

@gilbox
Copy link
Contributor

gilbox commented Oct 12, 2016

@joewoodhouse what errors are you getting? I don't see any above.

@joewoodhouse
Copy link

"AirGoogleMaps dir must be added to your project"

screen shot 2016-10-12 at 23 32 21

@gilbox
Copy link
Contributor

gilbox commented Oct 12, 2016

hmm 2 thoughts

  • This probably has nothing to do w/your Podfile since your app wouldn't even compile if you added the AirGoogleMaps dir without proper Podfile config
  • In JS, You can inspect NativeModules.UIManager to see what is available. It should have AIRGoogleMap and AIRMap as properties.

@joewoodhouse
Copy link

I have AIRMap (and AIRMapMarker, AIRMapCircle etc) but no AIRGoogleMap

@gilbox
Copy link
Contributor

gilbox commented Oct 12, 2016

you project looks like this?

image

@joewoodhouse
Copy link

screen shot 2016-10-12 at 23 58 49

@gilbox
Copy link
Contributor

gilbox commented Oct 12, 2016

excuse my ignorance, but do you know why your folder icons look different? also, if you are installing React as a pod shouldnt it be in the Pods/ dir (donno if that would make a difference though)

@joewoodhouse
Copy link

Not sure, I'm on XCode 8.0 if that makes any difference.

I've no idea if I'm installing React as a Pod or not to be honest, which probably isn't very helpful. Basically I've started a new project with react-native init then tweaked the index a bit to put a <MapView provider="google"/>, and now trying to install this module

@gilbox
Copy link
Contributor

gilbox commented Oct 12, 2016

  • Please remove AirMaps.xcodeproj from your project.
  • Are you opening an xcworkspace or an xcodeproj ?

@joewoodhouse
Copy link

I'm opening the .xcodeproj

@gilbox
Copy link
Contributor

gilbox commented Oct 12, 2016

Please review the cocoapods docs. You can't use GoogleMaps without using CocoaPods in your project.

@joewoodhouse
Copy link

On looking I see I am using Pods.

@ippa Did you get any further with this?

If someone could just write down some command-by-command instructions from react-native init to the point where the map runs on iOS using Google Maps, I think that would be really helpful.

@gilbox
Copy link
Contributor

gilbox commented Oct 12, 2016

If someone could just write down some command-by-command instructions from react-native init to the point where the map runs on iOS using Google Maps, I think that would be really helpful.

👍 👍 👍 👍 This would be an awesome contribution.

I suggest you become comfortable with pod install and understand the difference between xcodeproj and xcodeworkspace.

@Clcll
Copy link

Clcll commented Oct 20, 2016

@joewoodhouse Have you got the result ? I have the same problem

@joewoodhouse
Copy link

@Clcll Hi no sadly haven't made any progress with this myself. Was hoping one of the developers/contributors would be able to write up some steps.

@knkevinlai
Copy link

Same problem here, too.

  1. I found that in MyProject.xcodeproj > Build Settings > Framework Search Paths:
    both Debug and Release are having the paths of "${PODS_ROOT}/GoogleMaps/Subspecs/Base/Frameworks" and "${PODS_ROOT}/GoogleMaps/Subspecs/Maps/Frameworks"
    But In the MyProject.xcworkspace (after pod install) under folder tree of Pods, there are no such paths but only "Pods/GoogleMaps/Base/Frameworks" and "Pods/GoogleMaps/Maps/Frameworks"
  2. The path "problem" also exists in my MyProject.xcodeproj > Pods > Pods-MyProject.debug.xcconfig and MyProject.release.xcconfig
  3. After correcting the paths, problem still exist.

I wonder if this is related to the issue.

Thanks.

@mersay
Copy link

mersay commented Oct 30, 2016

@gilbox how do you inspect NativeModules.UIManager?

@Mjuk-Biltvatt
Copy link

@joewoodhouse Did you make any progress with this?

@ghost
Copy link

ghost commented Jun 4, 2017

I'm also having issues with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants