Fix initial region android #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2017
codedre
pushed a commit
to hzdg/react-native-maps
that referenced
this pull request
Aug 17, 2017
* Fix initial region on android * Fix initial region for android
sorodrigo
pushed a commit
to Vizzuality/react-native-maps
that referenced
this pull request
Aug 21, 2017
* 'master' of https://github.com/airbnb/react-native-maps: v0.16.2 Revert "Issue1176 improve ios marker performance by X100 (react-native-maps#1187)" Fix initial region android (react-native-maps#1563) v0.16.1 Enhance Podfile. (react-native-maps#1252) Update marker component (react-native-maps#1428) Add legalNotice constant (react-native-maps#1458) Issue1176 improve ios marker performance by X100 (react-native-maps#1187) Fix initial region native prop (react-native-maps#1546) fix `Archive` configuration for iOS builds (react-native-maps#1550) v0.16.0 Document MapView min/max zoom properties (react-native-maps#1538) Fix timing function used in AnimatedRegion.spring (react-native-maps#1479) Fix crashing the application when a user presses on the map and the Google Play Services need to be updated or at the moment of the process of updating (react-native-maps#1469) skip region monitoring if map object is null (react-native-maps#1443) Zoom level fixes (react-native-maps#1485) Attempt to fix crashes. A variant of react-native-maps#1403 but for another lifecycle method, as proposed by @Nelrohd. (react-native-maps#1464) Handle Android RN 0.47 breaking change (react-native-maps#1481) add MKTileOverlayRenderer (react-native-maps#1357) Add onMapReady callback (react-native-maps#1369)
computerjazz
added a commit
to computerjazz/react-native-maps
that referenced
this pull request
Sep 1, 2017
Reverts JS changes made in react-native-maps#1563 which broke initialRegion on iOS, causing the map to display a region centered around 0, 0.
christopherdro
pushed a commit
that referenced
this pull request
Sep 3, 2017
Reverts JS changes made in #1563 which broke initialRegion on iOS, causing the map to display a region centered around 0, 0.
pjaraherrera
pushed a commit
to pjaraherrera/react-native-maps
that referenced
this pull request
Sep 27, 2017
* Fix initial region on android * Fix initial region for android
pjaraherrera
pushed a commit
to pjaraherrera/react-native-maps
that referenced
this pull request
Sep 27, 2017
Reverts JS changes made in react-native-maps#1563 which broke initialRegion on iOS, causing the map to display a region centered around 0, 0.
|
The lines in MapView.js cause my map upon re-render to get reset to 0,0. After switching back to "const region = this.props.region || this.props.initialRegion;" I no longer have the 0,0 reset issue. |
erezrokah
pushed a commit
to rmrs/react-native-maps
that referenced
this pull request
Oct 29, 2017
Reverts JS changes made in react-native-maps#1563 which broke initialRegion on iOS, causing the map to display a region centered around 0, 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1546 which was not working on Android