[android]: New Google Maps SDK Renderer #4045
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
This PR provides access to the new Google Maps renderer on Android, as raised on #3991.
The new renderer can be enabled using the android prop
useNewRenderer
. The only thing to bear in mind is that the application will use the renderer of the first map that is used in your application, regardless of what this prop is past that first render. i.e. If the first map that shows in your application uses the latest renderer all other maps will use it. If the first map that shows in your application you uses the legacy renderer all other maps will use that one.An alternative approach to this PR would be to have a method that you can call on your App.js to set the renderer at app start time. I've implemented both approaches but decided to go with the prop in the end. Ultimately this is a design decision and would like to get your feedback.
How did you test this PR?
Tested it on a Samsung Galaxy Note 9. Also tested in on emulators that don't meet google requirements to verify that the legacy renderer was used as fallback.