Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android]: New Google Maps SDK Renderer #4045

Conversation

isidoro98
Copy link
Contributor

Does any other open PR do the same thing?

No

What issue is this PR fixing?

This PR provides access to the new Google Maps renderer on Android, as raised on #3991.

The new renderer can be enabled using the android prop useNewRenderer. The only thing to bear in mind is that the application will use the renderer of the first map that is used in your application, regardless of what this prop is past that first render. i.e. If the first map that shows in your application uses the latest renderer all other maps will use it. If the first map that shows in your application you uses the legacy renderer all other maps will use that one.

An alternative approach to this PR would be to have a method that you can call on your App.js to set the renderer at app start time. I've implemented both approaches but decided to go with the prop in the end. Ultimately this is a design decision and would like to get your feedback.

How did you test this PR?

Tested it on a Samsung Galaxy Note 9. Also tested in on emulators that don't meet google requirements to verify that the legacy renderer was used as fallback.

@isidoro98
Copy link
Contributor Author

isidoro98 commented Jan 3, 2022

@christopherdro thinking of changing this to be a function that users can call when they first start the app. The prop is a bit misleading because the use of the new renderer can only be set once.

I've already implemented it and tested it. Is ready on my local, what do you think? Which approach you think will be better?

// User would call this on their App.js
// What you think about the function name? Any other suggestion?
useLatestRenderer();

edit: Opened #4055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants