Fix missing subtitles on iOS #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of iOS 15, `discoverabilityTitle` is no longer displayed as the subtitle UIActions. Subtitles are not visible to iOS users of this package. This update brings them back!
|
Is this still a draft? |
|
I know this is still marked as draft, but it feels like a very innocuous change and seems safe to merge (plus pretty high impact, would be great to have the top level API fully operational) @Naturalclar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As of iOS 15,
discoverabilityTitleis no longer displayed as the subtitle UIActions. Subtitles are not visible to iOS users of this package. This update brings them back.Test Plan
WIP
Fixes: #536