Have backdrop always useNativeDriver={true} #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backdrop element is a simple view that only ever has its opacity animated, which _always_ works with `useNativeDriver={true}` (see https://facebook.github.io/react-native/docs/animations#caveats). This seems to be a no-brainer non-breaking performance improvement.
mmazzarolo
approved these changes
Feb 8, 2019
| @@ -491,7 +491,7 @@ class ReactNativeModal extends Component { | |||
| <TouchableWithoutFeedback onPress={onBackdropPress}> | |||
| <View | |||
| ref={ref => (this.backdropRef = ref)} | |||
| useNativeDriver={useNativeDriver} | |||
| useNativeDriver={true} | |||
| style={[ | |||
| styles.backdrop, | |||
There was a problem hiding this comment.
Makes sense (the idea initially was to allow custom styling for it, hence it was not a default).
Thank you for the PR.
|
Landed in v8.0.0-beta.1 🛬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backdrop element is a simple view that only ever has its opacity animated, which always works with
useNativeDriver={true}(see https://facebook.github.io/react-native/docs/animations#caveats).This seems to be a no-brainer non-breaking performance improvement which will help all users.