Update propagateSwipe to allow onSwipeComplete #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @kevkev-lii, thanks for the PR :) |
|
lol that pointless bureaucracy meant this never made it in after a year. |
|
I'd contribute to Open Source if I had much time on my hands. In future my companies will contribute I'm sure. Still, just saying like a UI, a streamlined process gets more engagement. The guy who made this looks like he created a github account just to fix it. I suspect the value of the work is significantly higher than the loss of a perfect PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently when you use propagateSwipe, you cannot perform an onSwipeComplete command. I have added code that allows for a user to perform onSwipeComplete when propagateSwipe is true.