Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix blinking modal on modal close #721

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix blinking modal on modal close #721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,19 +672,17 @@ export class ReactNativeModal extends React.Component<ModalProps, State> {
if (this.props.isVisible) {
this.open();
} else {
// animation is done here, so just need to actualize state
// if set state by 1 prop (showContent: false and then isVisible: false),
// then when showContent set false, render is called with isVisible: true
// and this leads to blinking when user closes modal (it is seen on ios devices)
this.setState(
{
showContent: false,
isVisible: false,
},
() => {
this.setState(
{
isVisible: false,
},
() => {
this.props.onModalHide();
},
);
this.props.onModalHide();
},
);
}
Expand Down