Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for Tizen and WebOS #703

Merged
merged 1 commit into from Dec 5, 2023

Conversation

gizomo
Copy link
Contributor

@gizomo gizomo commented Dec 5, 2023

Web applications at Tizen use Chromium. And in the latest versions of Tizen seems being a support of Network Information API. I tasted react-native-netinfo at Tizen TV device and emulator. The event 'change' fired only at application start. If the connection is lost, the TV displays a native warning, but the event in Web application is not fired.

Firstly I found at Tizen docs guide to get information about network using tizen API. But then I came across an official guide for Web apps where 'online' / 'offline' are used to watch network connection changes.

So I decided to make an additional check for Tizen to solve this problem. Now web application fires events on connection changes at Tizen TV device and emulator.

The same solution works for WebOS

Prevent using Network Information API at web applications for Tizen and WebOS
Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - this works for me, you thoughtfully answered my original question (thank you!) and this one is a clean diff so I'm not concerned that there is any unrelated change (also thank you!)

Let's go!

@mikehardy mikehardy merged commit 030887e into react-native-netinfo:master Dec 5, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 5, 2023
# [11.2.0](v11.1.1...v11.2.0) (2023-12-05)

### Features

* **web:** add support for Tizen and WebOS ([#703](#703)) ([030887e](030887e))
@matt-oakes
Copy link
Collaborator

🎉 This PR is included in version 11.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants