Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated internetReachability fetch abort #706

Merged
merged 1 commit into from Dec 12, 2023

Conversation

gizomo
Copy link
Contributor

@gizomo gizomo commented Dec 12, 2023

New solution for fetch abort with 'Cancel' promise as before (for browsers without full support of AbortController API).

Initiated after discussion with Tymofiev in #700

@Tymofiev
Copy link

@gizomo thanks for opening this PR! I think it should fix the issue I have, not sure if it's better this way than it was originally done, but I am fine with having it this way.

Can you please request a review from @mikehardy since Matt Oakes no longer works on the repo?

Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me - although for the avoidance of doubt I want to state clearly that you two appear to be the most interested parties - so I'm just approving things that look reasonable :-) - I appreciate the continued effort and if this still needs a follow-on I'll be listening but I don't use this feature so I won't likely notice any issues (or fixes) myself...

@mikehardy mikehardy merged commit d44d5a8 into react-native-netinfo:master Dec 12, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 12, 2023
## [11.2.1](v11.2.0...v11.2.1) (2023-12-12)

### Bug Fixes

* update internetReachability fetch abort ([#706](#706)) ([d44d5a8](d44d5a8))
@matt-oakes
Copy link
Collaborator

🎉 This PR is included in version 11.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Tymofiev
Copy link

@mikehardy okay, sounds good - thanks for approving this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants