Add userInteraction attr for user opened push #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvonabur
force-pushed
the
user_interaction
branch
from
7b7893f
to
274f081
Compare
|
Not working...Always getting false |
Dallas62
suggested changes
Sep 2, 2020
|
Hi @nishanttatva |
xvonabur
force-pushed
the
user_interaction
branch
from
274f081
to
2749007
Compare
|
@Dallas62 I've added requested changes. Feel free to review it again. |
|
@Naturalclar It would be great if you find time to look at this PR 😉 |
Dallas62
approved these changes
Sep 11, 2020
|
@Dallas62 thanks for the ping! I'll take a look at it soon |
Naturalclar
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
@xvonabur Thank you! The change looks good to me.
Would you be able to add an example usage in the README and example?
xvonabur
force-pushed
the
user_interaction
branch
from
1387559
to
2c72d68
Compare
xvonabur
force-pushed
the
user_interaction
branch
from
2c72d68
to
09d5526
Compare
|
@Naturalclar I've added example and information to README. Can you check it? |
|
@xvonabur thank you for the change! I've published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In my app I need to run some JS code after user clicked on local notification. I didn't find any way to determine the moment user clicked on it.
This PR adds additional
userInteractionattribute to userInfo for push messages that was opened by user.If somebody approve this changes, I'll add an example.
Compatibility