New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update example to RN0.61.5 #51
chore: update example to RN0.61.5 #51
Conversation
@@ -34,31 +30,13 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:( | |||
return YES; | |||
} | |||
|
|||
// Required to register for notifications | |||
- (void)application:(UIApplication *)application didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these methods still required as long as we continue to target iOS <10.0?
Also, maybe it is time to add the more recent, non-deprecated methods.
https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1623022-application?language=objc#declarations
@Naturalclar some changes have been made in the core: D19700061 Original summary: |
@ecreeth Thanks for letting me know! |
Regarding this line...
...this shorter version works for me (RN 61.5):
|
…ve-push-notification-ios into chore/updateExample
@Entryist Thanks so much for the info 👍 updated the example to use |
Summary
There seemed to be many people who are having trouble with using this library in RN 0.61.x, as shown in #43 and #50
I've upgraded the example directory to get it working with RN 0.61.5
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
example/App.js
)