Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code errors breaking the build #82

Merged
merged 2 commits into from Mar 18, 2020
Merged

Fix code errors breaking the build #82

merged 2 commits into from Mar 18, 2020

Conversation

rborn
Copy link
Contributor

@rborn rborn commented Mar 18, 2020

Fixed the code errors breaking the build with the last merge of #66

Test Plan

What's required for testing (prerequisites)?

Use the last merge fbcb2e7 and app won't build

What are the steps to reproduce (after prerequisites)?

Just try to build

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

Naturalclar
Naturalclar approved these changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rborn Thank you for the fix!

@Naturalclar Naturalclar merged commit e03429c into react-native-push-notification:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rborn @Naturalclar