Do not crash iOS Simulator #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ports changes suggested by @barbsicle to react-native-sensors latest version. Original Pull Request: react-native-sensors#132
Closed
DanielMSchmidt
approved these changes
Sep 13, 2018
bra-shelker
added a commit
to bra-shelker/react-native-sensors
that referenced
this pull request
Sep 13, 2018
|
I just created the same patch. Can we get this merged, please? |
|
Merging won't help, I am currently unable to deploy due to conditions on my machine :( plus I could not get semantic release to work to have this automated |
|
You may also want to implement the quick observable fix in Also, @swissmanu @miracle2k and whoever else is waiting on this, I have been running on my fork for quite awhile now, and I suggest that as a temporary workaround so you don't have to keep editing |
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kibolho
pushed a commit
to kibolho/react-native-sensors
that referenced
this pull request
Oct 7, 2023
This ports changes suggested by @barbsicle to react-native-sensors latest version. Original Pull Request: react-native-sensors#132 BREAKING CHANGE: we change that we reject without an error now, which might change the usage for some folks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports changes suggested by @barbsicle to
react-native-sensorslatest version.Original Pull Request: #132
Changes included do not touch any JS implementation. It's iOS/Objective-C only.