Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientation sensor #349

Merged

Conversation

gramotei
Copy link
Contributor

Hello! I've added Orientation Sensor that returns rotation quaternion

Copy link
Member

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for the PR and addition to the project 👍 I know this is something a lot of people have waited for for a long time. I just have a few comments on the docs, if these are resolved we can merge it 👍

docs/API.md Show resolved Hide resolved
@DanielMSchmidt
Copy link
Member

Travis is red du to code formatting, npm run format should fix it

@gramotei
Copy link
Contributor Author

gramotei commented Nov 24, 2020

@DanielMSchmidt yeah I see it's red because of formatting but when I run format it also changes format of other files. not sure if its ok :) I can do it for sure if you don't mind

        modified:   docs/Changelog.md
        modified:   docs/Usage.md
        modified:   examples/BasicSensors/App.js
        modified:   examples/BasicSensors/SensorView.js
        modified:   examples/GryoscopeImage/App.js
        modified:   examples/KeepTheBallGame/App.js
        modified:   examples/KeepTheBallGame/Ball.js
        modified:   examples/KeepTheBallGame/Game.js
        modified:   examples/KeepTheBallGame/GameOver.js
        modified:   tests/App.js
        modified:   tests/SensorView.js
        modified:   tests/e2e/init.js
        modified:   website/core/Footer.js
        modified:   website/i18n/en.json
        modified:   website/pages/en/index.js
        modified:   website/siteConfig.js

@DanielMSchmidt
Copy link
Member

Thanks for the help 👍 Yeah I'll commit them right away, sorry that this fell on your PR :(

@DanielMSchmidt DanielMSchmidt merged commit 3d216e7 into react-native-sensors:master Dec 15, 2020
@kirkryan
Copy link

kirkryan commented Feb 8, 2021

Hi all, I have version 7.0.2 and can see this was committed into react-native-sensors but it seems to be unavailable in the current code - did the fail above prevent the merge and if what are the next steps and how can I help?

DanielMSchmidt referenced this pull request Feb 9, 2021
added a feature commit to trigger CI to release a minor version
@DanielMSchmidt
Copy link
Member

It did not prevent the merge, we just forgot to change the d.ts files accordingly in this PR. Could you create a follow-up PR?

@gramotei
Copy link
Contributor Author

gramotei commented Feb 9, 2021

@DanielMSchmidt
Copy link
Member

Oh yeah, you are right, I wonder what the problem is 🤔

@kirkryan
Copy link

@gramotei @DanielMSchmidt - should we jump on a teams meeting and work it out? Would be great to get orientation in there! I'm on UK time, but happy to work around you guys.

@DanielMSchmidt
Copy link
Member

I am in EU timezone as well, but I have a full time job that is not React Native Sensors, so I don't really have the time to jump on the call. I can see if I can devote some time to this issue over the weekend

@kirkryan
Copy link

Thanks, @DanielMSchmidt and totally understood!

@kirkryan
Copy link

@DanielMSchmidt - so, I was able to branch off - create my own npm package based on the current code and voila it works. It looks like it just needs the npm package building for the react-native-sensors repo.

@ebrahimhassan121
Copy link

@DanielMSchmidt
you can install the code on the master using npm i react-native-sensors/react-native-sensors.git

@DanielMSchmidt
Copy link
Member

I think the deployment failed in general due to some strange error with prettier, I fixed the check now so that the tests should pass again, hope we can get a nice release out with all the features soonish

@kirkryan
Copy link

kirkryan commented Feb 18, 2021

I can confirm that the code works great - I pulled to my own repo and built a GitHub npm repo to test - so looking forward to coming back into the main branch once it's updated!

@DanielMSchmidt
Copy link
Member

🎉 This PR is included in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arthedza
Copy link

@DanielMSchmidt @gramotei Please update the documentation: sensor description is absolutely absent there.
#409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants