-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orientation sensor #349
Orientation sensor #349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you for the PR and addition to the project 👍 I know this is something a lot of people have waited for for a long time. I just have a few comments on the docs, if these are resolved we can merge it 👍
Travis is red du to code formatting, |
@DanielMSchmidt yeah I see it's red because of formatting but when I run format it also changes format of other files. not sure if its ok :) I can do it for sure if you don't mind
|
Thanks for the help 👍 Yeah I'll commit them right away, sorry that this fell on your PR :( |
Hi all, I have version 7.0.2 and can see this was committed into react-native-sensors but it seems to be unavailable in the current code - did the fail above prevent the merge and if what are the next steps and how can I help? |
added a feature commit to trigger CI to release a minor version
It did not prevent the merge, we just forgot to change the d.ts files accordingly in this PR. Could you create a follow-up PR? |
Hm. But I added them https://github.com/react-native-sensors/react-native-sensors/blob/master/index.d.ts ? |
Oh yeah, you are right, I wonder what the problem is 🤔 |
@gramotei @DanielMSchmidt - should we jump on a teams meeting and work it out? Would be great to get orientation in there! I'm on UK time, but happy to work around you guys. |
I am in EU timezone as well, but I have a full time job that is not React Native Sensors, so I don't really have the time to jump on the call. I can see if I can devote some time to this issue over the weekend |
Thanks, @DanielMSchmidt and totally understood! |
@DanielMSchmidt - so, I was able to branch off - create my own npm package based on the current code and voila it works. It looks like it just needs the npm package building for the react-native-sensors repo. |
@DanielMSchmidt |
I think the deployment failed in general due to some strange error with prettier, I fixed the check now so that the tests should pass again, hope we can get a nice release out with all the features soonish |
I can confirm that the code works great - I pulled to my own repo and built a GitHub npm repo to test - so looking forward to coming back into the main branch once it's updated! |
🎉 This PR is included in version 7.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@DanielMSchmidt @gramotei Please update the documentation: sensor description is absolutely absent there. |
Hello! I've added Orientation Sensor that returns rotation quaternion