Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yellow box warning "requires main queue setup since it overrides constantsToExport but doesn't implement requiresMainQueueSetup #330

Closed
esutton opened this issue Aug 3, 2018 · 2 comments
Closed

Yellow box warning "requires main queue setup since it overrides constantsToExport but doesn't implement requiresMainQueueSetup #330

esutton opened this issue Aug 3, 2018 · 2 comments

Comments

@esutton
Copy link
Collaborator

esutton commented Aug 3, 2018

Steps to reproduce

  1. Launch app with react-native-share in iOS ( simulator can reproduce )

Expected behaviour

No Yellow Box Warnings

Actual behaviour

ellow Box Warnings

Environment

iOS
"react": "16.3.1",
"react-native": "0.55.4",

react-native-share

	"react-native-share": "^1.1.0",

Link to repo (highly encouraged)

https://github.com/react-native-community/react-native-share/blob/71737360313e35216062036c8a60416dc2aefc80/ios/RNShare.m#L50

Below this in /ios/RNShare.m

@implementation RNShare
- (dispatch_queue_t)methodQueue
{
    return dispatch_get_main_queue();
}

Add:

+ (BOOL)requiresMainQueueSetup
{
    return YES;
}
esutton added a commit to esutton/react-native-share that referenced this issue Aug 3, 2018
@esutton
Silence Yellow box warning "requires main queue setup"
8624681 
react-native-share#330

Add:
````
+ (BOOL)requiresMainQueueSetup
{
    return YES;
}
````
@esutton esutton mentioned this issue Aug 3, 2018
Merged
@yeomann
Copy link
Collaborator

yeomann commented Aug 4, 2018

would appreciate if you can send fix via PR? @esutton

@jgcmarins
Copy link
Member

done #331

@bret-betcha bret-betcha mentioned this issue Jun 4, 2022
Closed
mobiledev7 added a commit to mobiledev7/react-native-share that referenced this issue Dec 12, 2022
@mobiledev7
Silence Yellow box warning "requires main queue setup"
d62362b 
react-native-share/react-native-share#330

Add:
````
+ (BOOL)requiresMainQueueSetup
{
    return YES;
}
````
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jgcmarins @yeomann @esutton