Remove twitter native support on iOS #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oamado
requested review from
jgcmarins,
MateusAndrade and
mikehardy
as code owners
|
What do you think about adding some notes about this? Maybe here: https://react-native-share.github.io/react-native-share/docs/troubleshooting-ios. We could point out to twitter docs regarding this. |
|
@MateusAndrade I just updated the documentation. Let me know if you see something that can be improved |
| @@ -17,8 +17,7 @@ - (void)shareSingle:(NSDictionary *)options | |||
| inAppBaseUrl:(NSString *)inAppBaseUrl { | |||
|
|
|||
| NSLog(@"Try open view"); | |||
| if([[UIApplication sharedApplication] canOpenURL:[NSURL URLWithString:inAppBaseUrl]]) { | |||
|
|
|||
| if(![serviceType isEqualToString:@"com.apple.social.twitter"] && [[UIApplication sharedApplication] canOpenURL:[NSURL URLWithString:inAppBaseUrl]]) { | |||
There was a problem hiding this comment.
What about assign this to a variable? Maybe an: shouldOpenUrl? Or something like this:
isSharingToTwitter:(BOOL*)sharingToTwitter = [serviceType isEqualToString:@"com.apple.social.twitter"];
if(!sharingToTwitter && [[UIApplication sharedApplication] canOpenURL:[NSURL URLWithString:inAppBaseUrl]]) {Sorry if its wrong, I don't know a lot about objective-c 😓
MateusAndrade
approved these changes
Nov 29, 2021
MateusAndrade
pushed a commit
that referenced
this pull request
Nov 29, 2021
## [7.3.2](v7.3.1...v7.3.2) (2021-11-29) ### Bug Fixes * **twitter:** remove twitter native support on iOS ([#1120](#1120)) ([3bccd59](3bccd59))
|
🎉 This PR is included in version 7.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mobiledev7
added a commit
to mobiledev7/react-native-share
that referenced
this pull request
Dec 12, 2022
## [7.3.2](react-native-share/react-native-share@v7.3.1...v7.3.2) (2021-11-29) ### Bug Fixes * **twitter:** remove twitter native support on iOS ([#1120](react-native-share/react-native-share#1120)) ([3bccd59](react-native-share/react-native-share@3bccd59))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As Twitter removed the support for the development kit, there is an issue in the visualization of a post. Related to #930
Test Plan
Share a tweet using the library, this will open the browser, and if the phone has the app, then the Twitter app will be launched correctly.