feat(android): add namespace to support AGP 8 #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiCalazans
requested review from
jgcmarins,
MateusAndrade and
mikehardy
as code owners
MateusAndrade
approved these changes
Sep 1, 2023
MateusAndrade
pushed a commit
that referenced
this pull request
Sep 1, 2023
# [9.4.0](v9.3.0...v9.4.0) (2023-09-01) ### Features * **android:** add namespace to support AGP 8 ([#1458](#1458)) ([238ebf4](238ebf4))
|
🎉 This PR is included in version 9.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Trivial change to support AGP 8 as mentioned here: react-native-community/discussions-and-proposals#671
Nicola mentioned also we shouldn't remove package attribute from AndroidManifest to not lose compatibility with AGP < 8. I don't think it's worth maintaining logic to remove that attribute contitionally since it will only cause a warning to users on AGP 8 and above.
ps: I acknowledged someone else already tried this change but they remove package attribute which is not ideal.
Test Plan
I did not build this locally since it's a trivial attribute addition.