fix(ios): fixed typo in RNShare.mm file #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the messenger share functionality is not working properly and that is due to the typo issue we made here.
mannyuiux
requested review from
jgcmarins,
MateusAndrade and
mikehardy
as code owners
MateusAndrade
approved these changes
Nov 13, 2023
MateusAndrade
pushed a commit
that referenced
this pull request
Nov 13, 2023
## [10.0.1](v10.0.0...v10.0.1) (2023-11-13) ### Bug Fixes * **ios:** fixed typo in RNShare.mm file ([#1484](#1484)) ([848132a](848132a))
|
🎉 This PR is included in version 10.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The messenger share functionality is not working properly due to the typo issue we made here.
Overview
The share functionality of Messenger is not working on iOS due to the condition mismatch and have analysed the code and found we made a typo in the constants file. Have fixed it. Kindly review and share feedback.
Test Plan
I did not build this locally since it's trivial.