Send email to predefined email address #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valioz
requested review from
jgcmarins,
MateusAndrade and
mikehardy
as code owners
|
@valioz thanks for helping us with that! On which applications did you tested your changes? (Outlook, Gmail, etc ) |
|
I have tested it on a Gmail and Yahoo mail (Android) |
|
This looks good to me. You can please update your base branch with the master version @valioz ? |
valioz
force-pushed
the
email-addressee
branch
2 times, most recently
from
318e796
to
1671244
Compare
MateusAndrade
previously approved these changes
Aug 17, 2019
|
HI @valioz , you can updated your base branch with the last changes on master? I tested this on both Android/IOS and it looks fine. |
valioz
force-pushed
the
email-addressee
branch
from
1671244
to
ace5756
Compare
MateusAndrade
approved these changes
Sep 4, 2019
|
@valioz thanks! 🎉 |
|
On iOS with the default email app (mail), the TO field is not working correctly, it's not being fill at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Support sending an email to a predefined email address.
It is based on PR #138 and PR #67, fixes issue #487.