Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Route ID Instead of Name #90

Closed
reergymerej opened this issue Mar 3, 2016 · 4 comments
Closed

Use Route ID Instead of Name #90

reergymerej opened this issue Mar 3, 2016 · 4 comments
Milestone

Comments

@reergymerej
Copy link
Contributor

It would be nice to use an ID instead of name to identify routes. In some cases, you'd want to use the same title for multiple routes. When observing the routeEmitter, you only get the name (aka user-friendly title), so you don't know which route was triggered.

For now, I'm using the titleComponent and titleProps to separate the name from visible title. It works, but it's extra cruft.

@davidLeonardi
Copy link
Contributor

Feel free to make a PR :)

On Thu, Mar 3, 2016 at 3:30 PM Jeremy Greer notifications@github.com
wrote:

It would be nice to use an ID instead of name to identify routes. In some
cases, you'd want to use the same title for multiple routes. When observing
the routeEmitter, you only get the name (aka user-friendly title), so you
don't know which route was triggered.

For now, I'm using the titleComponent and titleProps to separate the name
from visible title. It works, but it's extra cruft.


Reply to this email directly or view it on GitHub
#90
.

@reergymerej
Copy link
Contributor Author

@SEthX done and done!

I left it open and just included the route in addition to the route name. This way, existing code won't break and devs can query whatever they want instead of introducing an id requirement.

@davidLeonardi
Copy link
Contributor

Please refer to discussion ongoing in #91

@davidLeonardi davidLeonardi added this to the 0.9.0 milestone Mar 3, 2016
@charpeni
Copy link
Contributor

PR #91 was merged, I'll close thank you @reergymerej.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants