feat(ios): migrate from deprecated methods #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrzysztofMoch
force-pushed
the
feat/migrate-from-deprecated-methods
branch
from
df8b06a
to
6211b4d
Compare
16 tasks
KrzysztofMoch
force-pushed
the
feat/migrate-from-deprecated-methods
branch
6 times, most recently
from
723cda7
to
d1f29ee
Compare
freeboub
approved these changes
Jan 4, 2024
|
@KrzysztofMoch I approve the Pr, but I don't have time to test it for now. |
KrzysztofMoch
force-pushed
the
feat/migrate-from-deprecated-methods
branch
2 times, most recently
from
6400615
to
d1f29ee
Compare
KrzysztofMoch
force-pushed
the
feat/migrate-from-deprecated-methods
branch
from
d1f29ee
to
9356c7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #3425
Migrate
AVAsset.tracks(withMediaType:)andAVAsset.mediaSelectionGroup(forMediaCharacteristic:)to newer equivalentsThe diff on Github is pretty weird, so I recommend checking it in the editor
Why ?
To support visionOS and to improve performance by using async methods
Test plan