Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Android, ReactExoplayerView instance doesn't eliminate after JS component unmount. #3488

Closed
YangJonghun opened this issue Jan 19, 2024 · 3 comments

Comments

@YangJonghun
Copy link
Collaborator

YangJonghun commented Jan 19, 2024

Bug

Platform

  • Android

Environment info

Library version: 6.0.0-beta.4
Device: Android

Steps To Reproduce

  1. add below Log within onHostPause method
Log.d(TAG, "onHostPause: " + this.hashCode());
  1. mount <Video /> component
  2. move to background
  3. check log print properly (via Logcat)
ReactExoplayerView      <package name>      D  onHostPause: <instance hash code A>
  1. move to foreground
  2. unmount <Video /> component you created in step 2
  3. mount new <Video /> component
  4. move to background
  5. you can check stacked log
ReactExoplayerView      <package name>      D  onHostPause: <instance hash code A>
ReactExoplayerView      <package name>      D  onHostPause: <instance hash code B>
  1. repeat steps 5~9, you can see the logs overlap by the number of iterations.

Expected behaviour

  1. memory leak
  2. calling unnecessary lifecycle callback

FYI

This is not an issue in v5.2.1., something seems to have gone wrong with the update process so far

@KrzysztofMoch
Copy link
Collaborator

Thanks for PR!, will be included in 6.0.0-beta.5

@VMBindraban
Copy link

@KrzysztofMoch Do you have an ETA for the 6.0.0-beta.5 release?

@KrzysztofMoch
Copy link
Collaborator

Hey @VMBindraban, I am planing to make release this week (so max 5 days 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants